adopted-ember-addons / adopted-ember-addons/emberx-select

changelog for 2.2.3 appears to be incorrect

Ouverte
#202 4 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
198
Forks
77
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

We are in the process of upgrading emberx-select from 2.0.2 to 3.x, but because we still have some 2-way bindings, are attempting to do it in phases

The main issues we are trying to address are : 2 way bindings, contextual components, and fixing the `contains` to `includes` deprecation warning. Our goal was to jump up to 2.2.3 (where 2 way is still supported, and the deprecation is fixed, and contextual components are supported), then migrate/test and eventually update to 3.x

However, it seems like a lot of the fixes we expected to find in 2.2.3 as described in the changelog are not actually in 2.2.3, but are in 3.0.0. Perhaps the changelog could be updated to more accurately reflect these fixes?

This caused us a bunch of confusion until we were able to figure out why the expected fixes were not in place.

For reference, see the 2.2.2 -> 2.2.3 diff here:
https://github.com/thefrontside/emberx-select/compare/v2.2.2...v2.2.3

And compare it to the 2.2.3 -> 3.0.0 diff here:
https://github.com/thefrontside/emberx-select/compare/v2.2.3...v3.0.0

A number of the fixes that are listed under 2.2.3 in the changelog ( `contains` -> `includes`, fixes for `ember-source` in the version checker) are listed under 2.2.3, but are actually merged into 3.0.0

We ended up forking the library and creating a hotfix branch to fix the specific issues we had problems with so we can smooth our migration to 3.x (https://github.com/soxhub/emberx-select/tree/v2.2.3-hotfix)

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Piste de recherche

Start by comparing the linked 2.2.2 to 2.2.3 and 2.2.3 to 3.0.0 diffs, then inspect the current changelog. Verify where the listed `contains` to `includes` and `ember-source` version-checker fixes landed, and update the release entries so each change is attributed to the correct version.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
javascript
Domaine
documentation
Type d'issue
Documentation
Difficulté
2/5
Temps estimé
1-3 heures
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
42/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.