adopted-ember-addons / adopted-ember-addons/ember-sortable

Ember-sortable 4.0.0 crashes during build on ember-modifier

Abierto
#481 3 comentarios 0 reacciones 1 asignado Reclamado por @IgnaceMaes Ver en GitHub
Lenguaje dominante
TypeScript
Estrellas
299
Forks
159
Merge medio
4 d 6 h
PR fusionados (30 d)
4

Descripción

**Describe the bug**

When upgrading from `ember-sortable@3.0.1` to `ember-sortable@4.0.0` the following issue occurs during the build. Any idea what could be the cause here?

**To Reproduce**

Steps to reproduce the behavior:

Environment:
- Ember v3.28
- Node.js v14.19.1
- ember-sortable v4.0.0

Running `ember serve` results in the error at the bottom of this issue.

**Expected behavior**

The build to succeed. According to the README/CHANGELOG the versions of ember/node should be compatible.

**Screenshots**

/

**Additional context**

```
ERROR Summary:

- broccoliBuilderErrorStack: SyntaxError: /ember-modifier/-private/function-based/modifier.ts: Missing semicolon (37:10)

35 | // value from a `modifier()` call.
36 | export type FunctionBasedModifier =
> 37 | abstract new () => FunctionBasedModifierInstance;
| ^
38 |
39 | /**
40 | * The (optional) return type for a modifier which needs to perform some kind of
at Object._raise (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:776:17)
at Object.raiseWithData (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:769:17)
at Object.raise (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:737:17)
at Object.semicolon (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:9165:10)
at Object.tsParseTypeAliasDeclaration (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:6176:10)
at Object.tsParseDeclaration (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:6498:23)
at Object.tsTryParseExportDeclaration (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:6403:17)
at Object.parseExportDeclaration (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:6973:26)
at Object.maybeParseExportDeclaration (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:12946:31)
at Object.parseExport (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:12884:29)
- code: [undefined]
- codeFrame: /ember-modifier/-private/function-based/modifier.ts: Missing semicolon (37:10)

35 | // value from a `modifier()` call.
36 | export type FunctionBasedModifier =
> 37 | abstract new () => FunctionBasedModifierInstance;
| ^
38 |
39 | /**
40 | * The (optional) return type for a modifier which needs to perform some kind of
- errorMessage: ember-modifier/-private/function-based/modifier.ts: /ember-modifier/-private/function-based/modifier.ts: Missing semicolon (37:10)

35 | // value from a `modifier()` call.
36 | export type FunctionBasedModifier =
> 37 | abstract new () => FunctionBasedModifierInstance;
| ^
38 |
39 | /**
40 | * The (optional) return type for a modifier which needs to perform some kind of
in /var/folders/9h/5lcgcj596r94wnt0shgmjdjc0000gp/T/broccoli-281835QSMOpGE670Q/out-499-funnel
at broccoli-persistent-filter:Babel > [Babel: ember-modifier] (Babel: ember-modifier)
- errorType: Build Error
- location:
- column: [undefined]
- file: ember-modifier/-private/function-based/modifier.ts
- line: [undefined]
- treeDir: /var/folders/9h/5lcgcj596r94wnt0shgmjdjc0000gp/T/broccoli-281835QSMOpGE670Q/out-499-funnel
- message: ember-modifier/-private/function-based/modifier.ts: /ember-modifier/-private/function-based/modifier.ts: Missing semicolon (37:10)

35 | // value from a `modifier()` call.
36 | export type FunctionBasedModifier =
> 37 | abstract new () => FunctionBasedModifierInstance;
| ^
38 |
39 | /**
40 | * The (optional) return type for a modifier which needs to perform some kind of
in /var/folders/9h/5lcgcj596r94wnt0shgmjdjc0000gp/T/broccoli-281835QSMOpGE670Q/out-499-funnel
at broccoli-persistent-filter:Babel > [Babel: ember-modifier] (Babel: ember-modifier)
- name: Error
- nodeAnnotation: Babel: ember-modifier
- nodeName: broccoli-persistent-filter:Babel > [Babel: ember-modifier]
- originalErrorMessage: /ember-modifier/-private/function-based/modifier.ts: Missing semicolon (37:10)

35 | // value from a `modifier()` call.
36 | export type FunctionBasedModifier =
> 37 | abstract new () => FunctionBasedModifierInstance;
| ^
38 |
39 | /**
40 | * The (optional) return type for a modifier which needs to perform some kind of
- stack: SyntaxError: /ember-modifier/-private/function-based/modifier.ts: Missing semicolon (37:10)

35 | // value from a `modifier()` call.
36 | export type FunctionBasedModifier =
> 37 | abstract new () => FunctionBasedModifierInstance;
| ^
38 |
39 | /**
40 | * The (optional) return type for a modifier which needs to perform some kind of
at Object._raise (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:776:17)
at Object.raiseWithData (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:769:17)
at Object.raise (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:737:17)
at Object.semicolon (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:9165:10)
at Object.tsParseTypeAliasDeclaration (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:6176:10)
at Object.tsParseDeclaration (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:6498:23)
at Object.tsTryParseExportDeclaration (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:6403:17)
at Object.parseExportDeclaration (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:6973:26)
at Object.maybeParseExportDeclaration (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:12946:31)
at Object.parseExport (/node_modules/@babel/core/node_modules/@babel/parser/lib/index.js:12884:29)

=================================================================================

```

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.