adopted-ember-addons / adopted-ember-addons/ember-sortable

Drag-drop/clicks don't work with nested components

Aperta
#339 7 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
299
Fork
159
Merge medio
4g 6h
PR unite (30g)
4

Descrizione

**Description**
If the `item` inside `{{#item.handle}}` or `{{#group.item}}` is an ember component, this addon has some serious issues. I'll outline a few of them -

1. Each item can only be dragged once.
1. On mobile devices, the drag and drop doesn't work at all.
1. Any touch events/button clicks don't work on mobile devices

**To Reproduce**
1. Go to [twiddle](https://ember-twiddle.com/4d4bdfcd769382afdb6b3d8d4eb89608?openFiles=templates.index.hbs%2Ctemplates.components.my-component.hbs).
1. The twiddle uses `2.1.1` version of the addon but these issues exist in earlier versions as well. We use `1.12.3` and here's a [twiddle](https://ember-twiddle.com/50a9079f6f43dd54cd44ba7ab9b737f5?openFiles=templates.index.hbs%2Ctemplates.components.my-component.hbs) on that version which has similar issues.
1. To try it on mobile devices, you can easily [simulate](https://developers.google.com/web/tools/chrome-devtools/device-mode) mobile devices on Chrome or open it up on a real mobile device. I've tested on both.

**Expected behavior**
1. Drag and drop should work normally on desktop for nested components.
1. Drag and drop should work normally on mobile devices.
1. Button clicks and other touch events should work on mobile devices.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.