adopted-ember-addons / adopted-ember-addons/ember-pikaday

Doesn't work on `Ember 5`

Ouverte
#566 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
bug help-wanted
Langage dominant
JavaScript
Étoiles
156
Forks
164
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Clicking on `` on an `Ember 5.4` SPA (`Node 18.13`) has no effect, the component is completely inactive.

I realised that it is probably because of https://github.com/adopted-ember-addons/ember-pikaday/issues/550

And since that fix has yet to be released for some reason, I installed the commit containing the fix directly:

```
// package.json

dependencies: {
......,
....,
"ember-pikaday": "github:adopted-ember-addons/ember-pikaday#9471789a52dd6b3ed133df6d7834dfbfb010acb8"
}
```

Now when I run `ember s` the build breaks with:

```
ERROR Summary:

- broccoliBuilderErrorStack: Error: ENOENT: no such file or directory, lstat '/my-spa/node_modules/ember-pikaday/./dist/_app_/components/pikaday-input.js'
at Object.lstatSync (node:fs:1574:3)
at symlink (/my-spa/node_modules/symlink-or-copy/index.js:127:26)
at Function.symlinkOrCopySync [as sync] (/my-spa/node_modules/symlink-or-copy/index.js:101:5)
at Funnel._copy (/my-spa/node_modules/broccoli-funnel/index.js:500:19)
at Funnel.processFile (/my-spa/node_modules/broccoli-funnel/index.js:483:8)
at Funnel.applyPatch [as _applyPatch] (/my-spa/node_modules/broccoli-funnel/index.js:396:12)
at Funnel. (/my-spa/node_modules/broccoli-funnel/index.js:350:10)
at Array.forEach ()
at Funnel.processFilters (/my-spa/node_modules/broccoli-funnel/index.js:349:11)
at Funnel.build (/my-spa/node_modules/broccoli-funnel/index.js:259:10)
at TransformNodeWrapper.build (/my-spa/node_modules/broccoli/dist/wrappers/transform-node.js:71:39)
at /my-spa/node_modules/broccoli/dist/builder.js:185:30
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Builder.build (/my-spa/node_modules/broccoli/dist/builder.js:204:13)
at async Builder.build (/my-spa/node_modules/ember-cli/lib/models/builder.js:204:11)
- code: [undefined]
- codeFrame: ENOENT: no such file or directory, lstat '/my-spa/node_modules/ember-pikaday/./dist/_app_/components/pikaday-input.js'
- errorMessage: ENOENT: no such file or directory, lstat '/my-spa/node_modules/ember-pikaday/./dist/_app_/components/pikaday-input.js'
at Funnel
-~- created here: -~-
at Funnel.Plugin (/my-spa/node_modules/broccoli-plugin/index.js:7:31)
at new Funnel (/my-spa/node_modules/broccoli-funnel/index.js:57:10)
at Funnel (/my-spa/node_modules/broccoli-funnel/index.js:54:43)
at Class.treeForApp (/my-spa/node_modules/ember-pikaday/node_modules/@embroider/addon-shim/src/index.js:78:54)
at Class._treeFor (/my-spa/node_modules/ember-cli/lib/models/addon.js:634:33)
at Class.treeFor (/my-spa/node_modules/ember-cli/lib/models/addon.js:594:21)
at /my-spa/node_modules/ember-cli/lib/broccoli/ember-app.js:547:26
at Array.reduce ()
at EmberApp._addonTreesFor (/my-spa/node_modules/ember-cli/lib/broccoli/ember-app.js:545:32)
at EmberApp.addonTreesFor (/my-spa/node_modules/ember-cli/lib/broccoli/ember-app.js:569:17)
-~- (end) -~-
- errorType: Build Error
- location:
- column: [undefined]
- file: [undefined]
- line: [undefined]
- treeDir: [undefined]
- message: ENOENT: no such file or directory, lstat '/my-spa/node_modules/ember-pikaday/./dist/_app_/components/pikaday-input.js'
at Funnel
-~- created here: -~-
at Funnel.Plugin (/my-spa/node_modules/broccoli-plugin/index.js:7:31)
at new Funnel (/my-spa/node_modules/broccoli-funnel/index.js:57:10)
at Funnel (/my-spa/node_modules/broccoli-funnel/index.js:54:43)
at Class.treeForApp (/my-spa/node_modules/ember-pikaday/node_modules/@embroider/addon-shim/src/index.js:78:54)
at Class._treeFor (/my-spa/node_modules/ember-cli/lib/models/addon.js:634:33)
at Class.treeFor (/my-spa/node_modules/ember-cli/lib/models/addon.js:594:21)
at /my-spa/node_modules/ember-cli/lib/broccoli/ember-app.js:547:26
at Array.reduce ()
at EmberApp._addonTreesFor (/my-spa/node_modules/ember-cli/lib/broccoli/ember-app.js:545:32)
at EmberApp.addonTreesFor (/my-spa/node_modules/ember-cli/lib/broccoli/ember-app.js:569:17)
-~- (end) -~-
- name: Error
- nodeAnnotation: [undefined]
- nodeName: Funnel
- originalErrorMessage: ENOENT: no such file or directory, lstat '/my-spa/node_modules/ember-pikaday/./dist/_app_/components/pikaday-input.js'
- stack: Error: ENOENT: no such file or directory, lstat '/my-spa/node_modules/ember-pikaday/./dist/_app_/components/pikaday-input.js'
at Object.lstatSync (node:fs:1574:3)
at symlink (/my-spa/node_modules/symlink-or-copy/index.js:127:26)
at Function.symlinkOrCopySync [as sync] (/my-spa/node_modules/symlink-or-copy/index.js:101:5)
at Funnel._copy (/my-spa/node_modules/broccoli-funnel/index.js:500:19)
at Funnel.processFile (/my-spa/node_modules/broccoli-funnel/index.js:483:8)
at Funnel.applyPatch [as _applyPatch] (/my-spa/node_modules/broccoli-funnel/index.js:396:12)
at Funnel. (/my-spa/node_modules/broccoli-funnel/index.js:350:10)
at Array.forEach ()
at Funnel.processFilters (/my-spa/node_modules/broccoli-funnel/index.js:349:11)
at Funnel.build (/my-spa/node_modules/broccoli-funnel/index.js:259:10)
at TransformNodeWrapper.build (/my-spa/node_modules/broccoli/dist/wrappers/transform-node.js:71:39)
at /my-spa/node_modules/broccoli/dist/builder.js:185:30
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Builder.build (/my-spa/node_modules/broccoli/dist/builder.js:204:13)
at async Builder.build (/my-spa/node_modules/ember-cli/lib/models/builder.js:204:11)

=================================================================================
```

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Reproduce the failure with Ember 5.4 and Node 18.13 using the pinned 9471789a52dd6b3ed133df6d7834dfbfb010acb8 dependency. Inspect the ember-pikaday dist tree and @embroider/addon-shim treeForApp, focusing on the missing dist/_app_/components/pikaday-input.js path. Done means ember s builds successfully and PikadayInput responds to clicks.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
javascript
Domaine
build-system, frontend
Type d'issue
Bug
Difficulté
4/5
Temps estimé
3-5 jours
Activité
À l'abandon
Clarté
Plutôt claire
Accessibilité débutants
28/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.