adopted-ember-addons / adopted-ember-addons/ember-paper

paper-dialog opens into wrong parent if parent doesn't have an ID

未关闭
#857 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
879
派生
327
PR 合并指标
30 天内没有已合并 PR

描述

If you create two (or more) `paper-dialog`s and pass a different `parent` to each in the form of a jQuery object, but neither parent has an `id`, the `destinationId` computed property in `paper-dialog` will set both parents' `id` to `null-parent`. This results in both dialogs opening into the first parent.

This happens because the `destinationId` computed property attempts to append `-parent` to the dialog's `elementId` to form an `id` for the parent element - but `paper-dialog` is a tagless component, and therefore does not (and cannot) have an `elementId`.

One workaround for this issue is to ensure that every element which will be used as a `paper-dialog`'s `parent` has a (unique) `id`, as that will prevent the computed property from setting it to `null-parent`.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。