adopted-ember-addons / adopted-ember-addons/ember-paper

paper-dialog opens into wrong parent if parent doesn't have an ID

オープン
#857 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
JavaScript
スター
879
フォーク
327
PR マージ指標
30日以内にマージされた PR はありません

説明

If you create two (or more) `paper-dialog`s and pass a different `parent` to each in the form of a jQuery object, but neither parent has an `id`, the `destinationId` computed property in `paper-dialog` will set both parents' `id` to `null-parent`. This results in both dialogs opening into the first parent.

This happens because the `destinationId` computed property attempts to append `-parent` to the dialog's `elementId` to form an `id` for the parent element - but `paper-dialog` is a tagless component, and therefore does not (and cannot) have an `elementId`.

One workaround for this issue is to ensure that every element which will be used as a `paper-dialog`'s `parent` has a (unique) `id`, as that will prevent the computed property from setting it to `null-parent`.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。