adopted-ember-addons / adopted-ember-addons/ember-paper

growTextarea may be called against destroyed component

未關閉
#856 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
JavaScript
星號
879
分支
327
PR 合併指標
30 天內沒有已合併 PR

描述

Using `1.0.0-beta.2`, I had the following error reported to sentry:

> Cannot read property 'addClass' of undefined

From the `growTextarea` method.

The code looks like this:

```javascript
let inputElement = this.$('input, textarea');
inputElement.addClass('md-no-flex').attr('rows', 1);
```

We probably just miss a check against 'isDestroying' and 'isDestroyed' before trying to apply `growTextarea`.

貢獻指南

開啟貢獻指南

研究方向

Start by locating the `growTextarea` method and read how it is invoked during component teardown. Reproduce or trace the reported `addClass` error, then verify that the method no longer operates on a destroyed component and that the existing behavior remains intact.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
javascript
領域
frontend
Issue 類型
缺陷
難度
2/5
預估耗時
1-3 小時
活躍度
停滯
描述清晰度
描述清楚
新手友好度
42/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。