adopted-ember-addons / adopted-ember-addons/ember-paper

paper-button async aware

Open
#569 10 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
879
Forks
327
PR merge metrics
No merged PRs in 30d

Description

Would be nice if the paper-button could be async aware, that is accept a promise as a return value on the `onClick` action, mainly for the form usecase.

```hbs
{{#paper-button type='submit' onClick=(action returnsPromise)}}
Submit
{{else}}
Submitting..
{{/paper-button}}
```

Or if the form component handles the action, it could pass down the promise in the yields:

```hbs
{{#paper-form onsubmit=(action withPromise) as |f|}}
{{#f.submit-button}}
Submit
{{else}}
Submitting..
{{/f.submit-button}}
{{/paper-form}}
```

Where the form passed it down:
```hbs
{{yield (hash
submit-button=(component 'paper-button' promise=submitPromise)
)}}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.