adopted-ember-addons / adopted-ember-addons/ember-paper
Update components to be on par with angular material v1
- Dominant language
- JavaScript
- Stars
- 879
- Forks
- 327
- PR merge metrics
- No merged PRs in 30d
Description
Angular material has reached v1.0.0.
It is now a good time for us to update ember-paper to be on par with angular material.
## Component List
- [x] #119 Pull angular material sass styles into the build pipeline (@miguelcobain in https://github.com/miguelcobain/ember-paper/commit/d001c4a8e77c8b4d68b48cfe503abeaba5ec84e6 and @mike1o1 in https://github.com/miguelcobain/ember-paper/commit/e85fc2ee61fcf4288eec40c18af05413d3733f1a)
- [x] import core styles
- [x] review color palettes and theming
- [x] review layout (there is now a class-based thing? See [under the hood section](https://material.angularjs.org/latest/layout/introduction)) (@mellatone and @miguelcobain in https://github.com/miguelcobain/ember-paper/issues/507)
- [x] we've decided to use classes and get rid of the attributes. The reason is that classes are the only way to have a consistent API across components and html elements.
- [x] remove all references to layout attributes and replace them with layout classes
- [x] remove FlexMixin as the use of classes should make it useless
- [ ] use a more meaningful file structure (see https://github.com/miguelcobain/ember-paper/issues/82#issuecomment-167522109) (sync with @saladfork)
- [x] Update components
- [x] Autocomplete (@xomaczar @ibarrick @miguelcobain in https://github.com/miguelcobain/ember-paper/pull/395)
- [x] Button (@jorgelainfiesta in https://github.com/miguelcobain/ember-paper/pull/324)
- [x] Card (@joukevandermaas in #341)
- [x] Checkbox (@miguelcobain in https://github.com/miguelcobain/ember-paper/pull/285)
- [x] Grid list (@Subtletree https://github.com/miguelcobain/ember-paper/pull/739)
- [x] Icons (@peec in https://github.com/miguelcobain/ember-paper/pull/275 )
- [x] Input (@DanChadwick @miguelcobain in https://github.com/miguelcobain/ember-paper/pull/326)
- [x] List, Divider and List controls
- [x] list and list controls (@miguelcobain in https://github.com/miguelcobain/ember-paper/pull/577)
- [x] divider (@andybeesee in https://github.com/miguelcobain/ember-paper/pull/398)
- [x] Menu (@xomaczar @ibarrick @miguelcobain in https://github.com/miguelcobain/ember-paper/pull/395)
- [x] Progress circular (@miguelcobain in https://github.com/miguelcobain/ember-paper/commit/1a9b6411a8ca30f3e9440d8585dc0f1ff4ff7649)
- [x] Progress linear (@peec in https://github.com/miguelcobain/ember-paper/pull/277)
- [x] Radio and radio group (@miguelcobain in https://github.com/miguelcobain/ember-paper/pull/286)
- [x] RippleMixin (@peec in https://github.com/miguelcobain/ember-paper/pull/275 )
- [x] Select (@xomaczar @ibarrick @miguelcobain in https://github.com/miguelcobain/ember-paper/pull/395)
- [x] Sidenav (@miguelcobain in #384)
- [x] Slider (@mansona in #572)
- [x] Switch (@jorgelainfiesta in https://github.com/miguelcobain/ember-paper/pull/293)
- [x] Toolbar (@miguelcobain in https://github.com/miguelcobain/ember-paper/pull/367)
- [x] Virtual repeat (@xomaczar @ibarrick @miguelcobain in https://github.com/miguelcobain/ember-paper/pull/395)
- [ ] New components
- [x] Dialogs (@DanChadwick @mellatone @miguelcobain in https://github.com/miguelcobain/ember-paper/pull/308 https://github.com/miguelcobain/ember-paper/pull/325 https://github.com/miguelcobain/ember-paper/commit/1dd229581684ee032616df779f5510fe90b87d80 https://github.com/miguelcobain/ember-paper/commit/05608bfa3b52d270e83b77b880c1e03eade729c6)
- [x] don't use transitionend events for animation. Figure out a way to reuse ember-css-transitions "wait for animations" logic.
- [x] Chips (@mansona and @pauln in https://github.com/miguelcobain/ember-paper/pull/527)
- [x] Tabs (@mellatone @miguelcobain in [#753](https://github.com/miguelcobain/ember-paper/pull/753), [#755](https://github.com/miguelcobain/ember-paper/pull/755) and [bc90bea](https://github.com/miguelcobain/ember-paper/commit/bc90beae6194c0d12644ffdff4aff1caddadee72))
- [x] Tooltips (@miguelcobain in https://github.com/miguelcobain/ember-paper/pull/752)
- [x] Toasts (@mellatone in https://github.com/miguelcobain/ember-paper/pull/750)
- [x] Docs
- [ ] review the doc styling and needed primitives (tabs, code highlighting and overall styles)
Components should be updated using the automatically-imported Angular Material stylesheets. See
Angular Material v1.0.6 for reference: https://github.com/angular/material/tree/v1.0.6
## How to get started
For each component in the above list, one should:
1. do your work in a branch based on the [master](https://github.com/miguelcobain/ember-paper) branch.
2. angular-material 1.0 styles are now included. Check if we need to update our markup to conform the styles (the "hbs" part).
3. Double check for missing or buggy functionality (the "js" part, you can use the docs, the dummy app, to quickly test 1 and 2).
4. use new ember features when applicable (e.g closure actions, contextual components, ddau in general).
5. write/review tests. convert unit to integration tests. check angular material tests to make sure we're not forgetting anything.
6. update the docs if necessary. The website hosted at http://miguelcobain.github.io/ember-paper/ is the "dummy" app in the `tests/` folder. It's a regular ember application. Don't waste too much time on docs _for now_. We'll update the docs later using angular material docs for inspiration, where applicable.
7. document changes, especially breaking changes if any, in CHANGELOG.md (see other examples there)
Example commit (paper-progress-circular): https://github.com/miguelcobain/ember-paper/commit/1a9b6411a8ca30f3e9440d8585dc0f1ff4ff7649
Try to follow the same style.
**Current work for ember-paper v1 is being done at [master](https://github.com/miguelcobain/ember-paper/tree/master)** Reference in issues to branch `wip/v1.0.0` now refer to `master` as the wip branch was merged into master.
## FAQ
See this comment for some more info: [FAQ](https://github.com/miguelcobain/ember-paper/issues/249#issuecomment-185132647)
Contributor guide
Assessment
This issue has not been assessed yet.