adopted-ember-addons / adopted-ember-addons/ember-moment
When calling `deprecate` you must provide `for` in options. Missing options.for in "ember-moment.addon.helpers.moment-to-now" deprecation
- Lenguaje dominante
- JavaScript
- Estrellas
- 398
- Forks
- 120
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
Hello,
I'm getting this warning when using the `moment-to-now` helper.
It seems like [this deprecate](https://github.com/stefanpenner/ember-moment/blob/master/addon/helpers/moment-to-now.js#L9) should have a `for` option.
[According to the code of the `deprecate` method](https://github.com/emberjs/ember.js/blob/master/packages/@ember/debug/lib/deprecate.ts#L195) _options.for A namespace for the deprecation, usually the package name_
Would also be fixed by merging #338
Guía de contribución
Línea de trabajo
Start in addon/helpers/moment-to-now.js at the deprecate call identified in the issue. Add the missing options.for value described there, then run the helper's existing tests or reproduce the warning to verify that the deprecation no longer reports a missing namespace.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- javascript
- Área
- frontend
- Tipo de issue
- Error
- Dificultad
- 1/5
- Tiempo estimado
- Menos de una hora
- Estado de actividad
- Estancado
- Claridad
- Bien especificado
- Aptitud para principiantes
- 55/100