adopted-ember-addons / adopted-ember-addons/ember-moment

Assertion errors in Ember 3.10 - can be fixed in later ember-macro-helpers version

Open
#308 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
398
Forks
120
PR merge metrics
No merged PRs in 30d

Description

Hi,

ember-moment 7.8.1 depends on ember-macro-helpers ^2.1.0, but ember-macro-helpers fixed an Ember 3.10 incompatibility in 3.1.0 and up.

Would it be possible to update ember-moment to use the latest ember-macro-helpers, or loosen the dependency so that either may be allowed?

Thanks!

Contributor guide

Open the contributing guide

Research direction

Start by locating ember-moment's dependency declaration for ember-macro-helpers and compare the ^2.1.0 constraint with the version that fixes Ember 3.10 incompatibility. Update or loosen that dependency as appropriate, then verify the package can be used with Ember 3.10; the issue mentions no specific test or file.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.