adopted-ember-addons / adopted-ember-addons/ember-moment

Freeze moment for testing

Ouverte
#301 1 commentaire 6 réactions 0 personnes assignées Voir sur GitHub
enhancement
Langage dominant
JavaScript
Étoiles
398
Forks
120
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Hey! I've used this add-on for a long time and I has served my needs perfectly.

However, one thing that I'd like to see included in this add-on is a helper to freeze moment (i.e. override `moment.now`) in tests, namely acceptance tests. Below I show what the API could look like:

```js
import { module, test } from 'qunit';
import { setupRenderingTest } from 'ember-qunit';
import { render } from '@ember/test-helpers';
import hbs from 'htmlbars-inline-precompile';
import { setupMoment } from 'ember-moment/test-support';

module('Integration | Component | x-event/date', function(hooks) {
setupRenderingTest(hooks);
setupMoment(hooks, '2042-01-01');

test('it renders', async function(assert) {
// This component only displays today's date in the format "DD/MM/YYYY"
await render(hbs`{{x-event/date}}`);

assert.dom(this.element).hasText('01/01/2042');
});
});
```

This would allow (more) deterministic tests, instead of relying of always getting today's date to see if the behaviour(s) is(are) correct.

What do you think about this feature? Thanks! 😄

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.