adopted-ember-addons / adopted-ember-addons/ember-moment

hideAffix broken

Open
#299 0 comments 0 reactions 0 assignees View on GitHub
bug good first issue
Dominant language
JavaScript
Stars
398
Forks
120
PR merge metrics
No merged PRs in 30d

Description

```hbs
{{moment-from '2011-05-02' locale='en'}}
// 8 years ago

{{moment-from '2011-05-02' locale='en' hideAffix=true}}
// Invalid date
// Deprecation warning: value provided is not in a recognized RFC2822 or ISO format.
```

Expected: _8 years_

Ember 3.7.3
ember-moment 7.8.1
ember-cli-moment-shim 3.7.1

---

### Update

__Workaround:__

```hbs
{{moment-from '2011-05-02' (now) locale='en' hideAffix=true}}
```

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue with the two moment-from Handlebars examples in the report, then inspect the moment-from handling of hideAffix. Compare it with the supplied (now) workaround. Done means hideAffix=true produces “8 years” for the shown date without an invalid-date result or deprecation warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.