adopted-ember-addons / adopted-ember-addons/ember-moment
Falsy second parameter for `moment-format` doesn't use default format
- Dominant language
- JavaScript
- Stars
- 398
- Forks
- 120
- PR merge metrics
- No merged PRs in 30d
Description
Maybe I'm wrong but if the value of the second parameter passed to `moment-format` is a falsy value, I'd expect the date to be displayed in the default format.
That's currently not the case as the code checks the number of parameters passed explicitly and only uses `moment.outputFormat` (the default format set in the configuration):
https://github.com/stefanpenner/ember-moment/blob/v7.7.0/addon/helpers/moment-format.js#L28-L35
If it worked as I describe, the following:
```hbs
{{#with currentUser.user.dateFormat as |format|}}
{{moment-format date format}}
{{else}}
{{moment-format date}}
{{/with}}
```
could be written as:
```hbs
{{moment-format date format}}
```
Is this the intended behavior or can we get the default format in the case I described?
Contributor guide
Assessment
This issue has not been assessed yet.