adopted-ember-addons / adopted-ember-addons/ember-local-storage
PeerDependency `@ember/string` is missing
Abierto
- Lenguaje dominante
- JavaScript
- Estrellas
- 220
- Forks
- 78
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
The addon is using `@ember/string` but its not declared as peerDependency.
This makes impossible to use `@ember/string` v4 as its a v2 addon
https://github.com/funkensturm/ember-local-storage/blob/02112d14e475520a776f3eb97ef4bf918e10fd79/addon/helpers/storage.js#L1-L8
There are two options to fix this issue:
- adding `dasherize` as internal function (not braking - recommended)
- adding `@ember/string` as peerDependency (braking)
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.