adopted-ember-addons / adopted-ember-addons/ember-local-storage

PeerDependency `@ember/string` is missing

未关闭
#380 2 条评论 6 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
220
派生
78
PR 合并指标
30 天内没有已合并 PR

描述

The addon is using `@ember/string` but its not declared as peerDependency.

This makes impossible to use `@ember/string` v4 as its a v2 addon

https://github.com/funkensturm/ember-local-storage/blob/02112d14e475520a776f3eb97ef4bf918e10fd79/addon/helpers/storage.js#L1-L8

There are two options to fix this issue:
- adding `dasherize` as internal function (not braking - recommended)
- adding `@ember/string` as peerDependency (braking)

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。