adopted-ember-addons / adopted-ember-addons/ember-light-table

Fastboot support and SEO mode

Aberta
#468 0 comentários 0 reações 0 responsáveis Ver no GitHub
help wanted ideas-wanted new-feature
Linguagem predominante
JavaScript
Estrelas
311
Forks
130
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

I haven't used ember-light-table in Fastboot yet. I would expect that it should run without problems, since users haven't voiced complaints yet. Did someone already try it?

I think a Fastboot enabled SEO mode is an interesting idea. The markup generated by ELT is a bit strange. The table is fragmented into two / three separate `` tags. I can imagine that this doesn't make much sense to search engines / crawlers.

If we're running in Fastboot, we could generate a more standards compliant markup.

Fastboot currently has no notion of "rehydration", but rather rerenders the whole component and replaces the server-side generated tags. For the most part, I don't expect this to cause any problems / layout flashes. However, fixed headers / footers could cause weird behavior, because of vertically overflowing table content (rows).

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.