adopted-ember-addons / adopted-ember-addons/ember-light-table

Fastboot support and SEO mode

Đang mở
#468 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
help wanted ideas-wanted new-feature
Ngôn ngữ chính
JavaScript
Star
311
Fork
130
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

I haven't used ember-light-table in Fastboot yet. I would expect that it should run without problems, since users haven't voiced complaints yet. Did someone already try it?

I think a Fastboot enabled SEO mode is an interesting idea. The markup generated by ELT is a bit strange. The table is fragmented into two / three separate `` tags. I can imagine that this doesn't make much sense to search engines / crawlers.

If we're running in Fastboot, we could generate a more standards compliant markup.

Fastboot currently has no notion of "rehydration", but rather rerenders the whole component and replaces the server-side generated tags. For the most part, I don't expect this to cause any problems / layout flashes. However, fixed headers / footers could cause weird behavior, because of vertically overflowing table content (rows).

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.