adopted-ember-addons / adopted-ember-addons/ember-file-upload

Re-evaluate the peerDeps

未关闭
#1,139 0 条评论 2 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
TypeScript
星标
196
派生
115
PR 合并指标
30 天内没有已合并 PR

描述

https://github.com/adopted-ember-addons/ember-file-upload/pull/917 moved some dependencies to peerDependencies but I'm not sure if that was actually needed, or what the benefits are of doing that.

Other addons can also use ember-file-upload and they are forced to also list these as peerDep if they don't use the dependency themselves, which is strange.

Looking at the [current peerDep list](https://github.com/adopted-ember-addons/ember-file-upload/blob/1250c807d6572570a4c09cca1651fba7f6d48c91/ember-file-upload/package.json#L92-L99); `tracked-built-ins` and `ember-modifier` should be moved to dependencies, in my opinion.

I'm not sure about the `@glimmer/component` package, but I believe that one is a virtual package in an Ember app and only needed for the types (so a devDep is probably fine)?

These changes would not be breaking AFAIK, if the version ranges are kept the same.

贡献指南

打开贡献指南

调研方向

Start with ember-file-upload/package.json, especially the current peerDependencies entries referenced in the issue, and review PR 917 for the original change. Determine whether tracked-built-ins and ember-modifier belong in dependencies and whether @glimmer/component can be a devDependency, keeping the existing version ranges. Done means the manifest reflects the justified dependency categories without unrelated changes.

由索引模型根据 Issue 内容生成。

评估

技术栈
typescript
领域
tooling
Issue 类型
重构
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
基本清楚
新手友好度
48/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。