adopted-ember-addons / adopted-ember-addons/ember-file-upload
Re-evaluate the peerDeps
- Vorherrschende Sprache
- TypeScript
- Sterne
- 196
- Forks
- 115
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
https://github.com/adopted-ember-addons/ember-file-upload/pull/917 moved some dependencies to peerDependencies but I'm not sure if that was actually needed, or what the benefits are of doing that.
Other addons can also use ember-file-upload and they are forced to also list these as peerDep if they don't use the dependency themselves, which is strange.
Looking at the [current peerDep list](https://github.com/adopted-ember-addons/ember-file-upload/blob/1250c807d6572570a4c09cca1651fba7f6d48c91/ember-file-upload/package.json#L92-L99); `tracked-built-ins` and `ember-modifier` should be moved to dependencies, in my opinion.
I'm not sure about the `@glimmer/component` package, but I believe that one is a virtual package in an Ember app and only needed for the types (so a devDep is probably fine)?
These changes would not be breaking AFAIK, if the version ranges are kept the same.
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.