adopted-ember-addons / adopted-ember-addons/ember-drag-sort

Inform the developer that they've missed `draggable="true"` on the drag handle

未關閉
#18 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
enhancement
主要語言
JavaScript
星號
93
分支
33
PR 合併指標
30 天內沒有已合併 PR

描述

I've just spent more time than I'd care to admit debugging an issue which I initially thought was caused by attempting to use `ember-drag-sort` within an `ember-paper` dialog, as I'd been happily using it outside the dialog, but it didn't want to work at all within it. It turned out that I'd missed `draggable="true"` on my drag handle - but there was no indication that this was the case (other than nothing being draggable).

It would be ideal if either:
- The drag handle didn't require `draggable="true"` (though I'm not sure how feasible that would be);
- The drag handle automatically had `draggable="true"` set on it if missing;
- `ember-drag-sort` raised some sort of warning (at least in dev) if a handle selector is provided but the handle doesn't have `draggable="true"`; or
- The `handle` selector was ignored if the handle didn't have `draggable="true"`, perhaps by adding an attribute selector to the `handle` selector in the `drag-sort-item`'s `$handle` computed property and using `$handle` instead of `handle` in the `draggable` computed property.

If it'll help, I can look at submitting a PR - just let me know what the preferred approach is.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。