adopted-ember-addons / adopted-ember-addons/ember-data-model-fragments

Array attribute typing seems to be wrong

未关闭
#457 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug good first issue
主要语言
TypeScript
星标
367
派生
108
PR 合并指标
30 天内没有已合并 PR

描述

The following line suggest that `array` attribute takes in two arguments, type and options.
https://github.com/adopted-ember-addons/ember-data-model-fragments/blob/cfa5e5e1716d2508a13a0e973cf5b51c45bedb79/addon/attributes.js#L151

Whereas the existing type information defined in the line below suggest `array` attribute does not take any arguments:
https://github.com/adopted-ember-addons/ember-data-model-fragments/blob/cfa5e5e1716d2508a13a0e973cf5b51c45bedb79/attributes.d.ts#L33

贡献指南

打开贡献指南

调研方向

Compare the runtime signature for `array` in addon/attributes.js at line 151 with its declaration in attributes.d.ts at line 33. Update the type information so it matches the arguments accepted by the runtime, then verify that the declaration and usage are consistent.

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript, typescript
领域
developer-experience, frontend
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
描述清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。