adopted-ember-addons / adopted-ember-addons/ember-data-factory-guy

Returning inherited models of various types

Aberta
#231 6 comentários 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
JavaScript
Estrelas
298
Forks
136
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

Hello!

I ran into a problem while writing tests for our application. We have a certain backend route that can return various models inherited from a single base model. When I tried to mock it, I found out that the mock replaces the types of the supplied model instances with the type specified as the modelName for the mock, so the data aren't loaded properly.

To illustrate this, I wrote a simple test based on your test setup:

``` javascript
test("mock returns inherited models with proper types", function(assert) {
const smallHat = make('small-hat');
const bigHat = make('big-hat');
let mock = mockQuery('hat', { size: 'all' }).returns({ models: [smallHat, bigHat] });
let responseData = mock.responseJson.data;
equal(responseData[0].type, 'small-hat');
equal(responseData[1].type, 'big-hat');
});
```

As it turned out, the data type specified in the JSON is `'hat'` in both cases.

I would greatly appreciate your suggestions on handling this situation.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.