adopted-ember-addons / adopted-ember-addons/ember-cli-flash
Using a modifier for flash-message component
Aperta
- Lingua principale
- TypeScript
- Stelle
- 355
- Fork
- 118
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Would there be any interest in moving the current flash logic from the flash-message component, into a modifier?
Thinking it could be (somewhat) backwards compatible, the current flash-message component would end up looking like this;
```hbs
// flash-message.hbs
{{#if hasBlock}}
{{yield this @flash (action "onClose")}}
{{else}}
{{@flash.message}}
{{/if}}
```
It would also allow users of this addon to make custom flash components with relative ease if they wish to do so, without having to implement all of the logic from the flash message component.
```hbs
{{#each flashMessages.queue as |flash|}}
wow, that's all I have to do, don't even need a component
{{/each}}
```
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.