adopted-ember-addons / adopted-ember-addons/ember-cli-content-security-policy

Support Ember Auto Import without requiring manual configuration

Aperta
#159 0 commenti 1 reazione 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
JavaScript
Stelle
157
Fork
44
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Ember Auto Import is a default dependency of new Ember applications and addons. It violates default CSP by default. Its configuration must be adjusted manually to be compatible with Ember CLI Content Security Policy. It is documented both in [our documentation](https://github.com/rwjblue/ember-cli-content-security-policy#ember-auto-import) as well as in [Ember Auto Import's documentation](https://github.com/ef4/ember-auto-import#i-use-content-security-policy-csp-and-it-breaks-ember-auto-import). While that documentation helps new adopters to resolve the issue it's still a terrible developer experience. We should provide compatibility out of the box.

Ember Auto Import is uninstalled in the test suite to not cause tests to fail. As soon as both addons are compatible by default this code should be removed. After that point the existing tests will also provide regression tests that a new project does not violate the default CSP. https://github.com/rwjblue/ember-cli-content-security-policy/blob/8c4067ada6c8a0a93106d0a2e08acd5c490329bd/node-tests/e2e/test-support-test.js#L25-L36

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.