adopted-ember-addons / adopted-ember-addons/ember-changeset
ember-inspector silently pollutes `changes`
- Linguagem predominante
- JavaScript
- Estrelas
- 425
- Forks
- 136
- Métricas de merge de PRs
- Nenhum PR com merge em 30d
Descrição
Changes are silently set to the changeset when ember-inspector is used (?) tracked it down to this line
https://github.com/emberjs/ember-inspector/blob/15f49e5ab04e738ec540550001ad8a1b1537eb70/ember_debug/object-inspector.js#L536
it triggers the proxy set and so `changeset.changes` is polluted.
In particular these properties:
`_oldWillDestroy`
`willDestroy`
Maybe it would be great to have an inverse of `changesetKeys`, a denylist, which the default could be these props
Guia de contribuição
Direção de pesquisa
Start at ember_debug/object-inspector.js line 536 and trace how the proxy set updates changeset.changes, then inspect changesetKeys and the listed _oldWillDestroy and willDestroy properties. Done means using ember-inspector no longer adds those properties to the changeset changes; verify the behavior with the existing test suite.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- javascript
- Domínio
- frontend
- Tipo de issue
- Bug
- Dificuldade
- 3/5
- Tempo estimado
- 1-2 dias
- Status de atividade
- Estagnada
- Clareza
- Razoavelmente clara
- Facilidade para iniciantes
- 35/100