adopted-ember-addons / adopted-ember-addons/ember-changeset

Modifying a buffered property of a changeset invalidates all buffered properties

Abierto
#437 9 comentarios 1 reacción 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
425
Forks
136
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Got a weird one here. Not sure if it's intentional but I suspect not. Essentially, changing any buffered property of an ember-changeset causes the observers of all buffered properties to fire (i.e. the whole buffer is invalidated). If you have an underlying object with lots of properties and associated DOM, this can get real messy, real fast. I put together a basic repro that shows (clearly, I hope) the differences in behavior between a POJO and an ember-changeset.

## Version
3.0.6

## Test Case
https://github.com/mwpastore/-ember-changeset-notify

![](https://media.giphy.com/media/ZZlmKrS9jt0JMAjyMk/giphy.gif)

## Steps to reproduce
Modify any buffered property of a changeset.

## Expected Behavior
Only observers of the modified property should fire.

## Actual Behavior
Observers of all properties fire.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.