adopted-ember-addons / adopted-ember-addons/ember-changeset

Modifying a buffered property of a changeset invalidates all buffered properties

Offen
#437 9 Kommentare 1 Reaktion 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
JavaScript
Sterne
425
Forks
136
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

Got a weird one here. Not sure if it's intentional but I suspect not. Essentially, changing any buffered property of an ember-changeset causes the observers of all buffered properties to fire (i.e. the whole buffer is invalidated). If you have an underlying object with lots of properties and associated DOM, this can get real messy, real fast. I put together a basic repro that shows (clearly, I hope) the differences in behavior between a POJO and an ember-changeset.

## Version
3.0.6

## Test Case
https://github.com/mwpastore/-ember-changeset-notify

![](https://media.giphy.com/media/ZZlmKrS9jt0JMAjyMk/giphy.gif)

## Steps to reproduce
Modify any buffered property of a changeset.

## Expected Behavior
Only observers of the modified property should fire.

## Actual Behavior
Observers of all properties fire.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.