adopted-ember-addons / adopted-ember-addons/ember-changeset-validations

Update to ember-validates v4 is breaking change

Open
#314 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
215
Forks
98
PR merge metrics
No merged PRs in 30d

Description

V4 of ember-validates includes a significant breaking change (dropping momentJS) for anyone who uses their date validated.

We pulled this change in without realising though a minor update to Ember-changesets-validations which didn't indicate it included a breaking change.

just a suggestion to try to flag stuff like this through a major version bump, or a change log.

thanksFor maintaining such an awesome lib, 🙏🏻

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.