adopted-ember-addons / adopted-ember-addons/ember-changeset-validations

Multi field validation (i.e. one of must be present) can result in incorrect `isValid` state

Ouverte
#192 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
215
Forks
98
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

This might be more of a feature request than a bug (at least with the provided validators).

I have implemented a validator which checks for presence OR for the presence of other fields (so at least one of the fields must be "present" for the validator to pass). Currently there is no way to call validation for these other fields as the actual `changeset` is not passed to the validator function (just the changes and the model).

The only "workaround" right now is to call validate on the main changeset validating all fields, but this means that before that happens, the isValid state is incorrect (and errors for said fields might be present on the changeset).

This is likely also an issue for the validator proposed in #189 / #191

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.