adobe / adobe/aio-cli-plugin-cloudmanager

pipeline:create-execution: Write execution id to stdout

Offen
#224 11 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
help wanted
Vorherrschende Sprache
JavaScript
Sterne
50
Forks
36
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

It is useful to have the id of the newly created execution id available in the stdout (for non-interactive use cases).
This is not the case for https://github.com/adobe/aio-cli-plugin-cloudmanager/blob/b95ae82604c89f2bf8512c36cb7d5ca023dc1864/src/commands/cloudmanager/pipeline/create-execution.js#L35 as the spinner is overwriting output in stdout.

The only way to get hold of the output is via the {{-a}} option: https://github.com/wblachowski/cm-jenkins-helpers/blob/7762702130cec073abddef51eb4268a8d28465bd/jenkins-config/pipelines/pipeline-cm-deploy.Jenkinsfile#L14

The return value of of the run method is not evaluated. A table should be emitted similar to what is done in https://github.com/adobe/aio-cli-plugin-cloudmanager/blob/b95ae82604c89f2bf8512c36cb7d5ca023dc1864/src/commands/cloudmanager/execution/get-step-details.js#L42. That way both json and regular format could be supported.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start in src/commands/cloudmanager/pipeline/create-execution.js at the execution creation flow and compare its output handling with src/commands/cloudmanager/execution/get-step-details.js. Check how the run method's return value is currently handled; done means the new execution id is available on stdout without spinner interference, with both regular and JSON output supported.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
javascript
Bereich
cli
Issue-Typ
Feature
Schwierigkeit
2/5
Geschätzter Aufwand
1-3 Stunden
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
50/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.