adobe-fonts / adobe-fonts/source-han-sans

HK glyph for U+74CA 瓊 is incorrect

Đang mở
#288 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
Ngôn ngữ chính
Python
Star
17.2k
Fork
1.4k
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

Currently, the HK version of U+74CA 瓊 is mapped to `uni74CA-JP`. But this glyph doesn't fit HK's convention because of the difference in the bottom right component (攵 in HK/TW, 夂 in JP/CN/KR).

![uni74CA](https://user-images.githubusercontent.com/959433/110204847-3c8ab800-7eb0-11eb-8343-4b11e7b4926a.png)

This could be fixed simply by changing the mapping of the HK version of U+74CA to `uni74CA-TW`. However, this actually points to a larger problem.

There is one more glyph `uni74CAuE0101-JP` for U+74CA, which looks very similar to uni74CA-TW.

![uni74CA-e0101](https://user-images.githubusercontent.com/959433/110204913-8ecbd900-7eb0-11eb-9825-1498ed0d08a7.png)

There is a trivial difference - in uni74CAuE0101-JP, the last stroke ㇏ touches the first stroke 丿 of the 攵 component, while the two strokes don't touch in uni74CA-TW. The untouched design can also be found in the TW version of other 敻-composed glyphs, which is probably why a different glyph is needed for U+74CA.

![敻glyphs](https://user-images.githubusercontent.com/959433/110204957-e23e2700-7eb0-11eb-8b98-8bd2d7d0b165.png)

But I’d argue this is a unifiable difference and such distinction is unneccessary because:

1. In U+657B 敻, all regions including TW and HK share the same glyph (`uni657B-CN`), with the last stroke of 攵 touching the first stroke.

![uni657B](https://user-images.githubusercontent.com/959433/110204992-07329a00-7eb1-11eb-8392-1c0a50164575.png)

2. In fact, the "touched" version of the 攵 component is used in all other codepoints, no matter which region the glyph is mainly designed for.

![攵glyphs](https://user-images.githubusercontent.com/959433/110205011-22050e80-7eb1-11eb-8441-18fdd916bab0.png)

Thus, the design of the 攵 component in all TW glyphs with the 敻 component is actually inconsistent with the other part of the font.

To conclude, I believe a better fix would be to (1) map TW and HK version of U+74CA 瓊 to `uni74CAuE0101-JP` (which design is better than uni74CA-TW), (2) modify `uni77CE-TW` (矎), `uni85D1-TW` (藑), `uni89FC-TW` (觼), `uni8B82-TW` (讂) so that the design of 攵 in this 4 glyphs align with the font design, and (3) remove the current `uni74CA-TW` to save one CID for other use.

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.