addyosmani / addyosmani/vlc.js

Playlist support needs stability fixes

オープン
#5 コメント 0 件 リアクション 1 件 担当者 2 名 @addyosmani が担当を希望しています GitHub で見る
主要言語
JavaScript
スター
26
フォーク
7
PR マージ指標
30日以内にマージされた PR はありません

説明

If I am playing a video, open a new video to be added to the playlist and then try to view the playlist view and select that video here is what happens (messaging failures):

```js
2player.js:84 [VLC] Aborted(Assertion failed: prev, at: /home/asenat/workspaces/vlc/vlc.js/vlc/include/vlc_atomic.h,59,vlc_atomic_rc_inc)
printErr @ player.js:84
worker.onmessage @ experimental.js:1402Understand this warning
experimental.js:1105 Error while decoding:
experimental.js:1106 EncodingError: Decoder error.
experimental.js:464 Uncaught (in promise) RuntimeError: Aborted(Assertion failed: prev, at: /home/asenat/workspaces/vlc/vlc.js/vlc/include/vlc_atomic.h,59,vlc_atomic_rc_inc)
at abort (experimental.js:464:25)
at ___assert_fail (experimental.js:1554:17)
at imports. (experimental.js:11005:44)
at experimental.wasm.picture_InternalClone (experimental.wasm:0x1380b81)
at experimental.wasm.picture_pool_Wait (experimental.wasm:0x1382091)
at experimental.wasm.waitPictureFromPool (experimental.wasm:0x4cd9b8)
at ret. (experimental.js:11024:44)
at experimental.js:478:28
at output (experimental.js:1090:33)
abort @ experimental.js:464
___assert_fail @ experimental.js:1554
imports. @ experimental.js:11005
$picture_InternalClone @ experimental.wasm:0x1380b81
$picture_pool_Wait @ experimental.wasm:0x1382091
$waitPictureFromPool @ experimental.wasm:0x4cd9b8
ret. @ experimental.js:11024
(anonymous) @ experimental.js:478
output @ experimental.js:1090Understand this error
player.js:84 [VLC] Pthread 0x02083b48 sent an error! http://localhost:5174/experimental.worker.js:1: Uncaught RuntimeError: Aborted(Assertion failed: prev, at: /home/asenat/workspaces/vlc/vlc.js/vlc/include/vlc_atomic.h,59,vlc_atomic_rc_inc)
printErr @ player.js:84
worker.onerror @ experimental.js:1412Understand this warning
experimental.js:1413 Uncaught ErrorEvent {isTrusted: true, message: 'Uncaught RuntimeError: Aborted(Assertion failed: p…js/vlc/include/vlc_atomic.h,59,vlc_atomic_rc_inc)', filename: 'http://localhost:5174/experimental.worker.js', lineno: 1, colno: 1370, …}
worker.onerror @ experimental.js:1413Understand this error
experimental.js:464 Uncaught (in promise) RuntimeError: Aborted(Assertion failed: prev, at: /home/asenat/workspaces/vlc/vlc.js/vlc/include/vlc_atomic.h,59,vlc_atomic_rc_inc)
at abort (experimental.js:464:25)
at ___assert_fail (experimental.js:1554:17)
at imports. (experimental.js:11005:44)
at experimental.wasm.picture_InternalClone (experimental.wasm:0x1380b81)
at experimental.wasm.picture_pool_Wait (experimental.wasm:0x1382091)
at experimental.wasm.waitPictureFromPool (experimental.wasm:0x4cd9b8)
at ret. (experimental.js:11024:44)
at experimental.js:478:28
at output (experimental.js:1090:33)
abort @ experimental.js:464
___assert_fail @ experimental.js:1554
imports. @ experimental.js:11005
$picture_InternalClone @ experimental.wasm:0x1380b81
$picture_pool_Wait @ experimental.wasm:0x1382091
$waitPictureFromPool @ experimental.wasm:0x4cd9b8
ret. @ experimental.js:11024
(anonymous) @ experimental.js:478
output @ experimental.js:1090Understand this error
player.js:84 [VLC] Pthread 0x02083b48 sent an error! http://localhost:5174/experimental.worker.js:1: Uncaught RuntimeError: Aborted(Assertion failed: prev, at: /home/asenat/workspaces/vlc/vlc.js/vlc/include/vlc_atomic.h,59,vlc_atomic_rc_inc)
printErr @ player.js:84
worker.onerror @ experimental.js:1412Understand this warning
experimental.worker.js:1 Uncaught RuntimeError: Aborted(Assertion failed: prev, at: /home/asenat/workspaces/vlc/vlc.js/vlc/include/vlc_atomic.h,59,vlc_atomic_rc_inc)
at abort (experimental.js:464:25)
at ___assert_fail (experimental.js:1554:17)
at imports. (experimental.js:11005:44)
at experimental.wasm.picture_InternalClone (experimental.wasm:0x1380b81)
at experimental.wasm.picture_pool_Wait (experimental.wasm:0x1382091)
at experimental.wasm.waitPictureFromPool (experimental.wasm:0x4cd9b8)
at ret. (experimental.js:11024:44)
at experimental.js:478:28
at output (experimental.js:1090:33)
abort @ experimental.js:464
___assert_fail @ experimental.js:1554
imports. @ experimental.js:11005
$picture_InternalClone @ experimental.wasm:0x1380b81
$picture_pool_Wait @ experimental.wasm:0x1382091
$waitPictureFromPool @ experimental.wasm:0x4cd9b8
ret. @ experimental.js:11024
(anonymous) @ experimental.js:478
output @ experimental.js:1090Understand this error
experimental.js:1413 Uncaught ErrorEvent {isTrusted: true, message: 'Uncaught RuntimeError: Aborted(Assertion failed: p…js/vlc/include/vlc_atomic.h,59,vlc_atomic_rc_inc)', filename: 'http://localhost:5174/experimental.worker.js', lineno: 1, colno: 1370, …}
worker.onerror @ experimental.js:1413Understand this error
experimental.worker.js:1 Uncaught RuntimeError: Aborted(Assertion failed: prev, at: /home/asenat/workspaces/vlc/vlc.js/vlc/include/vlc_atomic.h,59,vlc_atomic_rc_inc)
at abort (experimental.js:464:25)
at ___assert_fail (experimental.js:1554:17)
at imports. (experimental.js:11005:44)
at experimental.wasm.picture_InternalClone (experimental.wasm:0x1380b81)
at experimental.wasm.picture_pool_Wait (experimental.wasm:0x1382091)
at experimental.wasm.waitPictureFromPool (experimental.wasm:0x4cd9b8)
at ret. (experimental.js:11024:44)
at experimental.js:478:28
at output (experimental.js:1090:33)
abort @ experimental.js:464
___assert_fail @ experimental.js:1554
imports. @ experimental.js:11005
$picture_InternalClone @ experimental.wasm:0x1380b81
$picture_pool_Wait @ experimental.wasm:0x1382091
$waitPictureFromPool @ experimental.wasm:0x4cd9b8
ret. @ experimental.js:11024
(anonymous) @ experimental.js:478
output @ experimental.js:1090Understand this error
```

The correct behavior is that we should be able to play without issues any video selected in the playlist view (`playlist-panel`). I should be able to click on the filename of any entry to switch to playing that one.

Keep in mind this error was also in the stack:

```js
[VLC] Pthread 0x02083b48 sent an error! http://localhost:5174/experimental.worker.js:1: Uncaught RuntimeError: Aborted(Assertion failed: prev, at: /home/asenat/workspaces/vlc/vlc.js/vlc/include/vlc_atomic.h,59,vlc_atomic_rc_inc)
```

Image

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。