addyosmani / addyosmani/largescale-demo
Private variables vs instance properties
- Lingua principale
- JavaScript
- Stelle
- 137
- Fork
- 23
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Hi, this is more of a question than issue but can anyone explain why you might want to create errorNotice as a private variable in the first version of this module versus as a property on the instance in the second version? It seems in the first version you have to clean up the private variable whereas in the second version it will be removed when the instance is destroyed. Thanks!
```
// First version
app.core.define('#error', function(f){
var errorNotice;
return {
init: function(){
errorNotice = f.find('#alert')[0];
},
destroy: function(){
errorNotice = null;
}
}
});
// Second version
app.core.define('#error', function(f){
return {
init: function(){
this.errorNotice = f.find('#alert')[0];
},
destroy: function(){
// No longer need to null-out errorNotice
}
}
});
```
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Valutazione
Questa issue non è ancora stata valutata.