addyosmani / addyosmani/critical

Dynamically included stylesheets

Open
#611 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
10.3k
Forks
390
PR merge metrics
No merged PRs in 30d

Description

I have a project that use some dynamically included stylesheets from styles that are conditionally included for very page specific components.

I am running into an issue that because the template itself doesn't include this stylesheet with but rather it's being inserted via JS (don't worry I understand that this process could do with some improvement).

Even though my critical css is generating correctly, I am left with this warning for each css file that isn't found as a
`Warning: Missing base path. Consider 'base' option. https://goo.gl/PwvFVb`

Related: https://github.com/nystudio107/rollup-plugin-critical/issues/1

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.