addyosmani / addyosmani/critical

Add the option of a prefix path

Open
#578 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
10.3k
Forks
390
PR merge metrics
No merged PRs in 30d

Description

in my vite project, the html compiles whit a default url, this url is generated depending on some environment variables in the project so is a dynamic url

`http://localhost:4000/assets/index-awd12431.css`

so this CSS file exists in my dist folder but critical can't find the file because it is unable to search for a path with localhost.

so it will be nice to have a prefixPath option, this way it is possible to ignore the prefix and only search for the files in the current path

```ts
generate({
base: './dist',
inline: true,
src: 'index.html',
extract: true,
prefixPath: 'http://localhost:4000'
});
```
this will omit the `http://localhost:4000` part of the import and get this result `/assets/index-awd12431.css`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.