addyosmani / addyosmani/critical

critical does not work with a remote browser

Abierto
#376 7 comentarios 0 reacciones 0 asignados Ver en GitHub
enhancement help wanted
Lenguaje dominante
JavaScript
Estrellas
10.3k
Forks
390
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Running something like this doesn't work.
```js
const browser = puppeteer.connect({
browserWSEndpoint: 'ws://127.0.0.1:3000',
});

critical.generate({
src: 'https://www.google.com/',
penthouse: {
puppeteer: {
getBrowser: () => browser,
},
},
});
```

This results in an error.
```json
{
"errorMessage": "Protocol error (Page.navigate): Cannot navigate to invalid URL",
"errorType": "Error",
"stackTrace": [
"Error: Protocol error (Page.navigate): Cannot navigate to invalid URL",
"at Promise (C:\\Users\\user\\Projects\\project\\node_modules\\puppeteer-core\\lib\\Connection.js:185:56)",
"at new Promise ()",
"at CDPSession.send (C:\\Users\\user\\Projects\\project\\node_modules\\puppeteer-core\\lib\\Connection.js:184:12)",
"at navigate (C:\\Users\\user\\Projects\\project\\node_modules\\puppeteer-core\\lib\\FrameManager.js:119:39)",
"at FrameManager.navigateFrame (C:\\Users\\user\\Projects\\project\\node_modules\\puppeteer-core\\lib\\FrameManager.js:96:7)",
"at Frame.goto (C:\\Users\\user\\Projects\\project\\node_modules\\puppeteer-core\\lib\\FrameManager.js:407:37)",
"at Frame. (C:\\Users\\user\\Projects\\project\\node_modules\\puppeteer-core\\lib\\helper.js:111:23)",
"at Page.goto (C:\\Users\\user\\Projects\\project\\node_modules\\puppeteer-core\\lib\\Page.js:629:49)",
"at Page. (C:\\Users\\user\\Projects\\project\\node_modules\\puppeteer-core\\lib\\helper.js:111:23)",
"at loadPage (C:\\Users\\user\\Projects\\project\\node_modules\\penthouse\\lib\\core.js:54:30)",
"at Promise (C:\\Users\\user\\Projects\\project\\node_modules\\penthouse\\lib\\core.js:384:29)",
"at process._tickCallback (internal/process/next_tick.js:68:7)"
]
}
```
It tries to connect to `'file://C:\\Users\\user\\AppData\\Local\\Temp\\6df8ea397e6c2d676ff1b27a1e00f391\\79f06439b62759c632b77f71ef3d3cd0.html'`.

Would it somehow be possible to get this working using a remote browser? I'm running a headless chrome instance in a docker container which I let puppeteer connect to and it obviously can't connect to a local temp file.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.