addyosmani / addyosmani/agent-skills

Resolve skill-validator heuristic limitations before the PR-B test battery locks them in

Offen
#387 5 Kommentare 2 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
JavaScript
Sterne
93.8k
Forks
10k
Ø Merge
3 T. 15 Std.
Gemergte PRs (30 T.)
23

Beschreibung

Surfaced during review of #379. These are pre-existing behaviors of `scripts/lib/skill-lint.js`, not regressions from the extraction, but they should be triaged as bug-vs-intended before the PR-B test battery codifies the current heuristics as the contract:

- **Frontmatter parsing** is a YAML-like subset: it accepts malformed YAML and non-string descriptions, rejects valid folded/commented YAML, and mismeasures the real length of multiline descriptions.
- **Section checks** use substring matching, so headings inside fenced code blocks or `###` sub-headings can satisfy a required-section rule. Contract question to resolve: `docs/skill-anatomy.md` describes the sections as recommended and allows equivalent headings, while the validator treats the exact headings as required.
- **Cross-reference patterns** miss some reference styles already used in the corpus and can match references inside fenced examples.
- **Trigger check** is satisfied by a negative phrase such as "Do not use when...".

For each: decide whether the current behavior is the intended contract (and document it) or a bug to fix, so PR-B tests assert the decided behavior rather than freezing today's heuristics. Credit to @federicobartoli for surfacing these while reviewing #379.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.