addyosmani / addyosmani/agent-skills

Resolve skill-validator heuristic limitations before the PR-B test battery locks them in

Aperta
#387 5 commenti 2 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
93.8k
Fork
10k
Merge medio
3g 15h
PR unite (30g)
23

Descrizione

Surfaced during review of #379. These are pre-existing behaviors of `scripts/lib/skill-lint.js`, not regressions from the extraction, but they should be triaged as bug-vs-intended before the PR-B test battery codifies the current heuristics as the contract:

- **Frontmatter parsing** is a YAML-like subset: it accepts malformed YAML and non-string descriptions, rejects valid folded/commented YAML, and mismeasures the real length of multiline descriptions.
- **Section checks** use substring matching, so headings inside fenced code blocks or `###` sub-headings can satisfy a required-section rule. Contract question to resolve: `docs/skill-anatomy.md` describes the sections as recommended and allows equivalent headings, while the validator treats the exact headings as required.
- **Cross-reference patterns** miss some reference styles already used in the corpus and can match references inside fenced examples.
- **Trigger check** is satisfied by a negative phrase such as "Do not use when...".

For each: decide whether the current behavior is the intended contract (and document it) or a bug to fix, so PR-B tests assert the decided behavior rather than freezing today's heuristics. Credit to @federicobartoli for surfacing these while reviewing #379.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.