adamws / adamws/kle-ng

4.5u stabilizer is incorrect

Open Beginner friendly
#66 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
264
Forks
15
PR merge metrics
No merged PRs in 30d

Description

I noticed that 4.5u space stabilizer is drawn the same size as 3u. It doesn't seem to be correct. I once took it as 34.671mm from the center from https://web.archive.org/web/20240202070508/https://deskthority.net/wiki/Space_bar_dimensions#4.5_units_.2885mm_wide.2C_3_mounts.2C_34.671mm_apart.29 This website is down atm, thus webarchive link.

Then, it seems it was standardized as 35mm +-0.2mm: https://green-keys.info/en/japan-layout-alliance/#Technical-Drawings

Please, adjust the code according to the JLA-450. It'll be also nice if it supports 4.25u spacebar properly as well.

the fix could be like this
```ts
// file src/utils/plate/plate-dimensions.ts

export function getCherryMxStabilizerSpacing(keySize: number): number | null {
if (keySize >= 8) return 66.675
if (keySize >= 7) return 57.15
if (keySize >= 6.25) return 50
if (keySize >= 6) return 47.625
if (keySize >= 4.5) return 35
if (keySize >= 4.25) return 30
if (keySize >= 3) return 19.05
if (keySize >= 2) return 11.938
return null
}
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in src/utils/plate/plate-dimensions.ts and inspect getCherryMxStabilizerSpacing, comparing its current size thresholds with the JLA-450 and linked spacing references in the issue. Done means 4.5u no longer uses 3u spacing and 4.25u receives its proper spacing without breaking the existing sizes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.