acts-project / acts-project/acts

Move some Digitization code from FATRAS to Core?

Aperta
#2,230 6 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Stale
Lingua principale
C++
Stelle
131
Fork
276
Merge medio
3g 13h
PR unite (30g)
112

Descrizione

During discussion with @pbutti we thought if some of the digitization code from the `FATRAS` package might better belong to `Core`. More precisely, from the Classes and files in `Fatras/Digitization` only the `UncorrelatedHitSmearer.hpp` depends on `ActsFatras::Hit`

All other files in that directory only depend on each other or on Core functionality, these are:
```
Channelizer.hpp ChannelMerger.hpp DigitizationData.hpp DigitizationError.hpp PlanarSurfaceDrift.hpp PlanarSurfaceMask.hpp
```
as well as
```
Channelizer.cpp DigitizationError.cpp PlanarSurfaceDrift.cpp PlanarSurfaceMask.cpp
```

So these don't depend on any of the FATRAS infrastructure.

Are there conceptual or design considerations for keeping this in FATRAS?

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.