acts-project / acts-project/acts

Track nDoF only returns the sum of calibrated size and not the actual DoFs.

Aperta
#2,076 6 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Improvement Stale
Lingua principale
C++
Stelle
131
Fork
276
Merge medio
3g 13h
PR unite (30g)
112

Descrizione

I think that the computation of the DoF of a track is wrong.
At the moment it is returning just the sum of the calibrated size.
https://github.com/acts-project/acts/blob/main/Core/include/Acts/EventData/TrackHelpers.hpp#L46
I think shouldbe NDoF=(sum of calibrated size) - fit parameters.
I have a doubt about time. Do we count the time in the DoF or not if there are no time measurements?
I think it should be -5 for a 3D track and -6 for a 4D track (i.e. if there is at least one time measurement). If there are only 3D measurements than time is a function on the other 5 TPs, hence not a DoF. Can the TrackHelpers tool be improved to reflect this or is the idea to leave it to the clients?
@paulgessinger @andiwand

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.