actix_router: Leaking strings causes LeakSanitizer noise
Aperta
A-router
- Lingua principale
- Rust
- Stelle
- 24.8k
- Fork
- 1.9k
- Merge medio
- 23h 10m
- PR unite (30g)
- 26
Descrizione
`ResourceDef` leaks strings [on purpose](https://github.com/actix/actix-net/blob/router-v0.2.7/actix-router/src/resource.rs#L63), which makes LeakSanitizer output rather messy, since the strings aren't explicitly free'd. I understand why this is (and why it's not a problem for execution), but this makes using LeakSanitizer rather ... unwieldy.
I'm also unsure what could be done here - dropping strings when the ResourceDef is dropped isn't exactly safe, and using `Rc` instead would (I guess) be a perf hit.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.