actix / actix/actix-web

actix_router: Leaking strings causes LeakSanitizer noise

Abierto
#2,547 0 comentarios 1 reacción 0 asignados Ver en GitHub
A-router
Lenguaje dominante
Rust
Estrellas
24.8k
Forks
1.9k
Merge medio
23 h 10 min
PR fusionados (30 d)
26

Descripción

`ResourceDef` leaks strings [on purpose](https://github.com/actix/actix-net/blob/router-v0.2.7/actix-router/src/resource.rs#L63), which makes LeakSanitizer output rather messy, since the strings aren't explicitly free'd. I understand why this is (and why it's not a problem for execution), but this makes using LeakSanitizer rather ... unwieldy.

I'm also unsure what could be done here - dropping strings when the ResourceDef is dropped isn't exactly safe, and using `Rc` instead would (I guess) be a perf hit.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.