actix / actix/actix-web

[awc] Discrepancy about default headers in code and documentation

Abierto
#2,351 0 comentarios 1 reacción 0 asignados Ver en GitHub
Lenguaje dominante
Rust
Estrellas
24.8k
Forks
1.9k
Merge medio
23 h 10 min
PR fusionados (30 d)
26

Descripción

## Expected Behavior

`awc` behavior being consistent with its API documentation.

## Current Behavior

`awc` does not set `User-Agent` header by default, despite the presence of the following method, and its documentation:
https://github.com/actix/actix-web/blob/ea8bf361041b35aa281835540f1e8aba9679aceb/awc/src/builder.rs#L119-L124
Moreover, the `default_headers` attribute does not seem to be used anywhere but in this method.

## Possible Solution

I need your opinion here, to know if the doc should be fixed, or if default `User-Agent` header should be implemented.

I would be happy to contribute on a fix.

## Steps to Reproduce (for bugs)

## Context

## Your Environment

* Rust Version (I.e, output of `rustc -V`): 1.53.0
* awc Version: 2.0.3

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.