activeloopai / activeloopai/hivemind

Redact secrets on the Cowork transcript ingest path (+ tests)

Aperta
#308 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
1.6k
Fork
107
Merge medio
17h 30m
PR unite (30g)
6

Descrizione

Follow-up to #307 (secret redaction on capture).

#307 masks secrets before persist/embed on the four agent capturers + `uploadSummary`. The **Cowork transcript ingest** path (`src/mcp/cowork-ingest.ts`, `entriesForLine` → queued session rows) is NOT yet redacted — deferred because that file is ~35% covered and wiring redaction into #307 dragged the PR's coverage comment down.

**Scope:**
- Apply `redactSecrets(...)` to the serialized entry in `cowork-ingest.ts` (the `const serialized = JSON.stringify(entry)` site), matching the pattern in the agent capturers.
- Add a real test suite for `cowork-ingest.ts` (currently ~35%): cover `entriesForLine` (pure transcript→entries mapping) and assert a secret in a Cowork transcript entry is masked before it's queued/embedded.

Until this lands, secrets echoed in Cowork transcripts are captured verbatim.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.