activeloopai / activeloopai/hivemind

Perf: suffix-keyed reverse index for matchPythonSuffix (avoid O(files) scan per import)

未关闭
#236 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
TypeScript
星标
1.6k
派生
107
平均合并
17 小时 30 分钟
30 天内合并 PR
6

描述

## Context

`matchPythonSuffix` in `src/graph/resolve/cross-file.ts` resolves a dotted-absolute Python import by suffix-matching against the known-files set. For each lookup it does up to 4 target forms × a full linear scan of `knownFiles`:

```ts
for (const t of targets) { // 4 target forms
if (knownFiles.has(t)) return t;
for (const f of knownFiles) { // O(files) scan
if (f.endsWith(`/${t}`)) { ... }
}
}
```

So cross-file resolution over a Python repo is `O(calls × files × 4)`. Fine at current scale (graphiti = 117 files, instant), but it degrades on large monorepos.

## Proposal

Build a suffix-keyed reverse index **once** (alongside `buildExportIndex`), mapping every path suffix (`mod.py`, `sub/mod.py`, `pkg/sub/mod.py`) → list of files, then make `matchPythonSuffix` an O(1) lookup + ambiguity check with no per-call scan.

## Notes
- Raised by CodeRabbit on PR #228 (Perf, Medium). Deferred from that PR since it's an optimization, not a correctness fix.
- Keep the existing high-confidence semantics: exact (root-anchored) wins; single suffix match wins; multiple → drop (ambiguous).

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。