acmesh-official / acmesh-official/acme.sh

DNS Azure should support Private DNS Zone

Offen Anfängerfreundlich
#6,653 3 Kommentare 2 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Shell
Sterne
47.6k
Forks
5.7k
Ø Merge
6 T. 5 Std.
Gemergte PRs (30 T.)
15

Beschreibung

The dns_azure.sh currently only supports Public DNS Zones, by using the /dnszones/ api path. This is documented here: https://learn.microsoft.com/en-us/rest/api/dns/record-sets/create-or-update?view=rest-dns-2018-05-01&tabs=HTTP

By changing this parameter to "/privatednszones/", we can ensure that the DNS Zone is not a publicly accessible one. https://learn.microsoft.com/en-us/rest/api/dns/privatedns/record-sets/create-or-update?view=rest-dns-privatedns-2018-09-01&tabs=HTTP

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Open `dns_azure.sh` and locate where the Azure DNS API path for record-set operations is assembled with `/dnszones/`. Use the linked Azure docs to confirm the equivalent private endpoint shape, then update the relevant path segment to `/privatednszones/`. There is no test file named in the issue, so validate by running the Azure DNS provider flow in this repo and checking the request path it uses. Done means DNS updates are sent to Private DNS Zones instead of public DNS zone endpoints.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
shell
Bereich
cli
Issue-Typ
Feature
Schwierigkeit
1/5
Geschätzter Aufwand
Unter einer Stunde
Aktivitätsstatus
Ruhig
Klarheit
Klar beschrieben
Anfängerfreundlichkeit
84/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.