acmesh-official / acmesh-official/acme.sh

DNS Azure should support Private DNS Zone

Open
#6,653 3 comments 2 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
47.6k
Forks
5.7k
Avg merge
7d 1h
Merged PRs (30d)
16

Description

The dns_azure.sh currently only supports Public DNS Zones, by using the /dnszones/ api path. This is documented here: https://learn.microsoft.com/en-us/rest/api/dns/record-sets/create-or-update?view=rest-dns-2018-05-01&tabs=HTTP

By changing this parameter to "/privatednszones/", we can ensure that the DNS Zone is not a publicly accessible one. https://learn.microsoft.com/en-us/rest/api/dns/privatedns/record-sets/create-or-update?view=rest-dns-privatedns-2018-09-01&tabs=HTTP

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.