acm-udayton / acm-udayton/ACM-Meeting-Records

[TASK] Migrate business logic to services

オープン
#160 コメント 0 件 リアクション 0 件 担当者 2 名 @ethanlally が担当を希望しています GitHub で見る
enhancement
主要言語
Python
スター
7
フォーク
2
平均マージ
4日 23時間
マージ済み PR(30日)
2

説明

## Feature Description

Business logic should be moved from within the routes and blueprints to separate services. These services should be contained in a `app/services` directory, with files mirroring the blueprints where they would have previously been located.

## Why It's Worth Implementing

Not only does this make our app more consistent with best practices and increase maintainability and testing ease, it also is key to our process of decoupling the frontend and backend. These services will allow us to keep consistent business logic during the intermediate phase where we keep the existing Jinja template serving and also build out the RESTful API.

---

## Acceptance Criteria & Solution Requirements
*To close this issue, the following must be met (can be finalized in the comments):*
- [x] 1. Application runs as expected with the new feature integrated seamlessly.
- [x] 2. Code quality metrics are maintained, and linting has been considered in development.
- [x] 3. Testing metrics are maintained, and tests have been updated/added wherever relevant during development.
- [ ] 4. Documentation has been updated to reflect the changes made during development.
- [ ] 5. All business logic has been removed from the `app/blueprints` directory, and is instead kept in the `app/services` directory.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。